Skip to content

refactor: use useVisibleItems in vulnerability tree#2405

Merged
serhalp merged 1 commit intomainfrom
jg/visible-voolnerabools
Apr 7, 2026
Merged

refactor: use useVisibleItems in vulnerability tree#2405
serhalp merged 1 commit intomainfrom
jg/visible-voolnerabools

Conversation

@43081j
Copy link
Copy Markdown
Contributor

@43081j 43081j commented Apr 7, 2026

🔗 Linked issue

N/A

🧭 Context

Part of moving to the useVisibleItems composable.

📚 Description

Switches the vulnerability tree to use the new useVisibleItems
composable.

@43081j
feat: use useVisibleItems in vulnerability tree
fef1f6b 
Switches the vulnerability tree to use the new `useVisibleItems`
composable.
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 7, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Apr 7, 2026 8:56am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Apr 7, 2026 8:56am
npmx-lunaria Ignored Ignored Apr 7, 2026 8:56am

Request Review

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b09a2065-e73f-4cff-a53e-ab8911a9c9fb

📥 Commits

Reviewing files that changed from the base of the PR and between 15b53bf and fef1f6b.

📒 Files selected for processing (1)
  • app/components/Package/VulnerabilityTree.vue
📝 Walkthrough

Walkthrough

The VulnerabilityTree.vue component was refactored to replace its local showAllPackages state and manual array slicing with the useVisibleItems composable. The component now uses visiblePackages directly for rendering and controls the "show all packages" button visibility and behaviour through the composable's hasMorePackages and expandPackages properties instead of a boolean toggle mechanism.

Possibly related PRs

Suggested reviewers

  • serhalp
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description accurately describes the changeset, explaining the migration to useVisibleItems composable in the vulnerability tree.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jg/visible-voolnerabools

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ghostdevv
Copy link
Copy Markdown
Contributor

ghostdevv commented Apr 7, 2026

@43081j what's an easy way to test this?

@43081j
Copy link
Copy Markdown
Contributor Author

43081j commented Apr 7, 2026

https://npmxdev-git-jg-visible-voolnerabools-npmx.vercel.app/package/gulp/v/2.7.0

this one shows it under the vulnerabilities box. you can expand some of them that have many vulnerabilities.

@serhalp serhalp changed the title feat: use useVisibleItems in vulnerability tree refactor: use useVisibleItems in vulnerability tree Apr 7, 2026
@serhalp serhalp added this pull request to the merge queue Apr 7, 2026
Merged via the queue into main with commit 24ce294 Apr 7, 2026
25 checks passed
@serhalp serhalp deleted the jg/visible-voolnerabools branch April 7, 2026 17:39
@github-actions github-actions bot mentioned this pull request Apr 7, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhalp serhalp serhalp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@43081j @ghostdevv @serhalp